Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chain-ops): add check-kroma-mpt command #406

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented Dec 17, 2024

Description

Added check-kroma-mpt command. You can test it in devnet by executing below commands.

> cd kroma-chain-ops/cmd/check-kroma-mpt && go build -o check-kroma-mpt && export CHECK_KROMA_MPT_ACCOUNT="{privKey}" && ./check-kroma-mpt mpt

I tested the commands in devnet and confirmed all passed except for checkGPO, which contains the checks of BlobBaseFeeScalar and BaseFeeScalar. Those two variables should be set by calling SystemConfig contract which does not happen in devnet, so I tested checkGPO in mainnet.

@seolaoh seolaoh self-assigned this Dec 17, 2024
@seolaoh seolaoh requested a review from a team as a code owner December 17, 2024 08:48
Copy link
Contributor

coderabbitai bot commented Dec 17, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seolaoh seolaoh force-pushed the feat/check-kroma-mpt branch from ea9c426 to 091d011 Compare December 17, 2024 09:34
@seolaoh seolaoh force-pushed the test/distribute-fee-mpt branch from 347670f to e610b40 Compare December 17, 2024 09:59
@seolaoh seolaoh force-pushed the feat/check-kroma-mpt branch from 091d011 to 6f258ae Compare December 17, 2024 10:03
@seolaoh seolaoh force-pushed the test/distribute-fee-mpt branch from d705465 to 85f4990 Compare December 18, 2024 06:55
@seolaoh seolaoh requested a review from a team as a code owner December 18, 2024 06:55
@seolaoh seolaoh force-pushed the feat/check-kroma-mpt branch from 6f258ae to 9eb6546 Compare December 18, 2024 08:41
@seolaoh seolaoh requested review from sm-stack and Pangssu December 18, 2024 08:42
@seolaoh seolaoh force-pushed the test/distribute-fee-mpt branch from 85f4990 to 839536f Compare December 18, 2024 09:01
@seolaoh seolaoh force-pushed the feat/check-kroma-mpt branch from 9eb6546 to 48ab345 Compare December 18, 2024 09:01
@seolaoh seolaoh force-pushed the test/distribute-fee-mpt branch from 839536f to 553f007 Compare December 19, 2024 05:05
@seolaoh seolaoh force-pushed the feat/check-kroma-mpt branch from 48ab345 to 04e3e0c Compare December 19, 2024 05:37
Base automatically changed from test/distribute-fee-mpt to feat/zkvm-fault-proof December 19, 2024 06:37
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh merged commit 0e9eee0 into feat/zkvm-fault-proof Dec 19, 2024
3 checks passed
@seolaoh seolaoh deleted the feat/check-kroma-mpt branch December 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants