-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chain-ops): add check-kroma-mpt command #406
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ea9c426
to
091d011
Compare
347670f
to
e610b40
Compare
091d011
to
6f258ae
Compare
d705465
to
85f4990
Compare
6f258ae
to
9eb6546
Compare
85f4990
to
839536f
Compare
9eb6546
to
48ab345
Compare
839536f
to
553f007
Compare
48ab345
to
04e3e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added check-kroma-mpt command. You can test it in devnet by executing below commands.
I tested the commands in devnet and confirmed all passed except for
checkGPO
, which contains the checks ofBlobBaseFeeScalar
andBaseFeeScalar
. Those two variables should be set by callingSystemConfig
contract which does not happen in devnet, so I testedcheckGPO
in mainnet.