-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): replace challege testdata and enable zkVM challenge e2e test #408
test(e2e): replace challege testdata and enable zkVM challenge e2e test #408
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
f449dd1
to
7f1bcb2
Compare
48ab345
to
04e3e0c
Compare
7f1bcb2
to
b46dc5f
Compare
Could you remove zkVM tests in l2_challenger_test? Also please handle the challenge tests in Colosseum.t.sol (L734) |
bb1026f
to
55f25a3
Compare
55f25a3
to
72e9307
Compare
Updated challenge testdata for zkVM, and enabled zkVM challenge test at actions test.
The public input data given by SP1 prover was formatted in an unexpected way (8 bytes padded in front of each value), so I updated
ZKProofVerifier
contract to verify in a correct way.