-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nutrition stats #124
Comments
Thanks! We considered adding nutritinal information but decided not to because in our experience they semed not that realistic/accurate and thus not worth our time. If anyone would like to implement that though it would be a nice addition and should be not to hard to add. |
The trawling aspect is now implemented. The database, graphql and app still need to be changed. |
@uglrl nice, do you want to create a pull request? |
No, because the database etc. still has to be implemented. And the trawling still has some bugs |
Great that you want to contribute! 😄 I think the following things would be neccesarry to get this going:
Frontend:
Further proceedingsI think we can assemble this directly on the backend branch. @muety if anything is unclear or you have any further questions feel free to ask Edit: moved documentation images to another comment |
Awesome, very helpful! I'll start implementing API and app once you guys tell me the scraping- and database parts are done. |
Any news on this? :) |
Actually, yes! |
Awesome news, thanks for that 🙌 Will give it a go probably on the weekend. |
Quick update on my end: I managed to get everything set up locally and was able to implement UI for showing nutrition data on the app (inside the accordion, next to additives, etc.). Still need to adapt the database schema and persist nutrition information to the app database. Would be cool to get #133 merged soon, so I can work from a clean branch (had to do some small ad-hoc fixes to get the app compile since backend and frontend seem to have diverged a bit). Btw., one thing I struggled with while building my dev setup is the fact that the cron expressions for the scheduler apparently expect UTC datetimes instead of local ones 🤔. Perhaps worth mentioning in the environment variables section. |
#128 was only one half... but is now merged in main 🥳 |
Released on both Android and iOS today |
The app looks amazing, thanks a lot! As an additional feature, it would be super cool to also see nutrition stats for each meal, see here.
The text was updated successfully, but these errors were encountered: