Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nutrition resolving into nutrition feature branch #133

Merged
merged 12 commits into from
Feb 27, 2024

Conversation

Whatsuup
Copy link
Contributor

@Whatsuup Whatsuup commented Feb 20, 2024

Backend

Make sure, you have done de following before merging this pull request:

  • Your code is documented using doc comments.
  • You added appropriate logging in your code.
  • You added unit tests to all your implemented functions.
  • You ran cargo format and cargo clippy to format your code and check for improvements.

@Whatsuup
Copy link
Contributor Author

Already done by @uglrl.
I opened this PR without checking the current status.
I also couldn't estimate how much work it would be. It was only 4 lines of code.
Nevertheless, thank you @uglrl!

To do at least something, I ran the migration tests and checked them randomly. I didn't notice anything negative. Well done.

@worldofjoni
Copy link
Member

@Whatsuup are the database insertion methods also called (at the correct place)? I am not aware that that is already done.

@Whatsuup
Copy link
Contributor Author

Added env and nutrition update feature

@Whatsuup Whatsuup closed this Feb 20, 2024
@Whatsuup Whatsuup reopened this Feb 20, 2024
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
you need to run sqlx prepare so that the ci can run successfully

backend/src/layer/data/database/mealplan_management.rs Outdated Show resolved Hide resolved
backend/src/layer/data/database/mealplan_management.rs Outdated Show resolved Hide resolved
backend/src/layer/data/database/mealplan_management.rs Outdated Show resolved Hide resolved
@worldofjoni worldofjoni mentioned this pull request Feb 21, 2024
@worldofjoni worldofjoni merged commit bd6917c into nutrition_data Feb 27, 2024
1 check passed
@worldofjoni worldofjoni deleted the nutrition/logic branch February 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants