-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B/google api #113
B/google api #113
Conversation
Tests, docs and probably logging still needs to be done |
Codecov Report
@@ Coverage Diff @@
## backend #113 +/- ##
===========================================
+ Coverage 89.22% 89.50% +0.27%
===========================================
Files 38 41 +3
Lines 1541 1629 +88
===========================================
+ Hits 1375 1458 +83
- Misses 166 171 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you merge the changes from backend you can also add your component in server.rs and implement the neccessary config reader function.
after that we should search for todos to see whether all are resolved
looks good besides the noted comments.
All tests that fail depend on the json file. Idk where that file is or how that path gets passed by... |
Pull Request for initial Implementation
Backend
Make sure, you have done de following before merging this pull request:
cargo format
to format your code.cargo clippy
to check for improvements.