Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B/google api #113

Merged
merged 52 commits into from
Oct 28, 2023
Merged

B/google api #113

merged 52 commits into from
Oct 28, 2023

Conversation

Whatsuup
Copy link
Contributor

@Whatsuup Whatsuup commented Oct 24, 2023

Pull Request for initial Implementation

Backend

Make sure, you have done de following before merging this pull request:

  • Your code is documented using doc comments.
  • You added appropriate logging in your code.
  • You added unit tests to all your implemented functions.
  • You ran cargo format to format your code.
  • You ran cargo clippy to check for improvements.

@Whatsuup
Copy link
Contributor Author

Tests, docs and probably logging still needs to be done

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #113 (4061256) into backend (3eb099a) will increase coverage by 0.27%.
The diff coverage is 95.40%.

@@             Coverage Diff             @@
##           backend     #113      +/-   ##
===========================================
+ Coverage    89.22%   89.50%   +0.27%     
===========================================
  Files           38       41       +3     
  Lines         1541     1629      +88     
===========================================
+ Hits          1375     1458      +83     
- Misses         166      171       +5     
Files Coverage Δ
backend/src/layer/trigger/api/util.rs 79.31% <ø> (ø)
backend/src/startup/config.rs 95.00% <100.00%> (+1.45%) ⬆️
...end/src/layer/data/image_validation/api_request.rs 95.65% <95.65%> (ø)
.../layer/data/image_validation/google_api_handler.rs 92.30% <92.30%> (ø)
...rc/layer/data/image_validation/image_evaluation.rs 96.87% <96.87%> (ø)
backend/src/startup/server.rs 0.00% <0.00%> (ø)

backend/.env.example Show resolved Hide resolved
backend/.env.example Show resolved Hide resolved
backend/Cargo.toml Show resolved Hide resolved
backend/src/interface/image_validation.rs Outdated Show resolved Hide resolved
backend/src/interface/image_validation.rs Show resolved Hide resolved
backend/src/interface/image_validation.rs Outdated Show resolved Hide resolved
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of documentation

backend/src/layer/data/image_validation/api_request.rs Outdated Show resolved Hide resolved
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge the changes from backend you can also add your component in server.rs and implement the neccessary config reader function.

after that we should search for todos to see whether all are resolved

looks good besides the noted comments.

backend/.env.example Show resolved Hide resolved
backend/src/layer/data/image_validation/api_request.rs Outdated Show resolved Hide resolved
backend/src/layer/data/image_validation/api_request.rs Outdated Show resolved Hide resolved
backend/src/layer/data/image_validation/api_request.rs Outdated Show resolved Hide resolved
backend/src/layer/data/image_validation/api_request.rs Outdated Show resolved Hide resolved
@Whatsuup
Copy link
Contributor Author

Whatsuup commented Oct 26, 2023

All tests that fail depend on the json file. Idk where that file is or how that path gets passed by...
Local all test work.

backend/src/startup/config.rs Outdated Show resolved Hide resolved
backend/src/startup/config.rs Outdated Show resolved Hide resolved
@worldofjoni worldofjoni merged commit 8f0bb12 into backend Oct 28, 2023
6 of 7 checks passed
@worldofjoni worldofjoni deleted the b/google_api branch October 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants