Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run without ext. services #151

Merged

Conversation

uglrl
Copy link
Contributor

@uglrl uglrl commented Apr 19, 2024

Make sure, you have done de following before merging this pull request:

  • Your code is documented using doc comments.
  • You added appropriate logging in your code.
  • You added unit tests to all your implemented functions.
  • You ran cargo format and cargo clippy to format your code and check for improvements.

@uglrl uglrl linked an issue Apr 19, 2024 that may be closed by this pull request
@uglrl uglrl requested a review from worldofjoni April 19, 2024 17:37
@uglrl uglrl changed the title Added ability to run without ext. services by using preexisting mocks Added ability to run without ext. services Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (fe9c32b) to head (2b74329).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          41       41           
  Lines        1746     1746           
=======================================
  Hits         1619     1619           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you worked on that @uglrl!
I think it would be cleaner to add a command line option to the existing executable for running in isolated demo mode as this is mainly a code duplication. Similar to how the help page or should_migrate is done.
That could be tricky, however, because of the generic type parameters.

@uglrl
Copy link
Contributor Author

uglrl commented Apr 21, 2024

I thought about doing that, but decided against it, since it would make the normal code flow more difficult to read and understand.

@uglrl uglrl self-assigned this Apr 21, 2024
Copy link
Member

@worldofjoni worldofjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I think, however, that naming the fine just bin.rs inside the startup folder is very misleading---something like standalone_demo_bin.rs would be clearer.
Also, the usage of this standalone version should be mentioned in the backend readme.

@uglrl uglrl requested a review from worldofjoni September 9, 2024 09:28
@worldofjoni worldofjoni merged commit e251149 into main Sep 18, 2024
8 checks passed
@worldofjoni worldofjoni deleted the 135-ability-to-run-without-external-services-for-development branch September 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to run without external services for development
2 participants