Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B/better reports 2 #166

Merged
merged 15 commits into from
Jul 16, 2024
Merged

B/better reports 2 #166

merged 15 commits into from
Jul 16, 2024

Conversation

worldofjoni
Copy link
Member

@worldofjoni worldofjoni commented Jul 8, 2024

Second phase of better image report handling (#160), follow up to #164.

Contains:

  • RESTful admin API under /admin with BASIC auth
  • API endpoints to delete and verify images
  • one-click buttons in report mail to delete/verify image

TODO

  • human-readable admin API response
  • improve notification email for when image is deleted / verified (same content as report mail?)
  • tests for database access
  • test for image file deletion
  • test for command
  • maybe tests for admin API?

@worldofjoni worldofjoni self-assigned this Jul 8, 2024
@worldofjoni worldofjoni linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (fcab00e) to head (0723790).

Files Patch % Lines
backend/src/interface/api_command.rs 80.00% 6 Missing ⚠️
backend/src/layer/data/mail/mail_sender.rs 97.05% 1 Missing ⚠️
backend/src/layer/trigger/api/bin.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   92.56%   92.72%   +0.15%     
==========================================
  Files          39       41       +2     
  Lines        1615     1746     +131     
==========================================
+ Hits         1495     1619     +124     
- Misses        120      127       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@worldofjoni worldofjoni requested a review from Whatsuup July 9, 2024 07:31
backend/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Whatsuup Whatsuup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better REST API responses in browser

@worldofjoni worldofjoni marked this pull request as ready for review July 14, 2024 10:44
@worldofjoni worldofjoni requested a review from Whatsuup July 14, 2024 10:44
@worldofjoni worldofjoni merged commit fe9c32b into main Jul 16, 2024
8 checks passed
@worldofjoni worldofjoni deleted the b/better-reports-2 branch July 16, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More ergonomic image report reviews
2 participants