Skip to content

Bugfixes and simplifications #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

bonartm
Copy link

@bonartm bonartm commented Aug 11, 2020

some suggestions and bugfixes

  • put code back in the mobydick folder
  • used python -m pytest instead of pytest to test modules in another folder
  • corrected import statements
  • removed classes around test functions
  • removed articles that are not up to date anymore
  • minor bugfixes

@krother
Copy link
Owner

krother commented Sep 21, 2020

I took a closer look at your PR. Thanks for the suggestions! They all make sense to me. The only blocker is that I use an incompatible deployment process. I'd have to branch the mkdocs part out of the PR. Should be possible.

@bonartm
Copy link
Author

bonartm commented Jul 2, 2021

I will open a new pull request that just contains the content updates/ fixes.

@bonartm bonartm closed this Jul 2, 2021
@bonartm bonartm mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants