Fix ROWS_QUERY event parsing long queries #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok tx I will test later other version of mysql nad add to workflow tests as we got only mysql 5.7 😢 |
|
I have this problem, so hope it's possible to merge this soon. |
|
@krowinski can you give an update for the state of this PR? What does block you? Can i help somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event is containing an integer value of the length of the query which can be longer then first expected. This is not working with extra long queries. The test i had added with #112 had only a short query were it worked well. Because of the dynamic length of the query to catch also those i now utilize the header length of the full binlog event to get the query.
Also i added a testcase for this with an extra long query.
Hope this fits you @krowinski ... thanks for your time!