Skip to content

Commit

Permalink
remove references to RecomputePreviousN
Browse files Browse the repository at this point in the history
  • Loading branch information
kruckenb committed Jul 18, 2015
1 parent 86f1e47 commit f6b360c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
7 changes: 2 additions & 5 deletions services/continuous_querier/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ type Config struct {
// If this flag is set to false, both the brokers and data nodes should ignore any CQ processing.
Enabled bool `toml:"enabled"`

// The RecomputePreviousN setting provides guidance for how far back to recompute, the RecomputeNoOlderThan
// setting sets a ceiling on how far back in time it will go. For example, if you have 2 PreviousN
// and have this set to 10m, then we'd only compute the previous two intervals for any
// CQs that have a group by time <= 5m. For all others, we'd only recompute the previous window
// RecomputeNoOlderThan sets a ceiling on how far back in time recomputes will go.
RecomputeNoOlderThan toml.Duration `toml:"recompute-no-older-than"`

// ComputeRunsPerInterval will determine how many times the current and previous N intervals
Expand All @@ -35,7 +32,7 @@ type Config struct {

// ComputeNoMoreThan paired with the RunsPerInterval will determine the ceiling of how many times smaller
// group by times will be computed. For example, if you have RunsPerInterval set to 10 and this setting
// to 1m. Then for a group by time(1m) will actually only get computed once per interval (and once per PreviousN).
// to 1m. Then for a group by time(1m) will actually only get computed once per interval.
// If you have a group by time(5m) then you'll get five computes per interval. Any group by time window larger
// than 10m will get computed 10 times for each interval.
ComputeNoMoreThan toml.Duration `toml:"compute-no-more-than"`
Expand Down
3 changes: 0 additions & 3 deletions services/continuous_querier/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ func TestService_Run(t *testing.T) {
// Set RunInterval high so we can trigger using Run method.
s.RunInterval = 10 * time.Minute

// Only want one call to ExecuteQueryFn per CQ.
s.Config.RecomputePreviousN = 0

done := make(chan struct{})
expectCallCnt := 2
callCnt := 0
Expand Down

0 comments on commit f6b360c

Please sign in to comment.