Updates README.md #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhanvimenghani
requested review from
dinogun,
rbadagandi1,
bharathappali and
msvinaykumar
dinogun
reviewed
Aug 11, 2023
README.md
Outdated
Comment on lines
14
to
15
| 1. Cluster IP : In case of a minikube cluster ```minikube ip``` | ||
| 2. Kruize Port Number : ```kubectl -n monitoring get svc kruize --no-headers -o=custom-columns=PORT:.spec.ports[*].nodePort 2>/dev/null``` |
There was a problem hiding this comment.
Please convert this to commands that can be copy pasted
export CLUSTER_IP=$(minikube ip)
export KRUIZE_PORT=$(kubectl -n monitoring get svc kruize --no-headers -o=custom-columns=PORT:.spec.ports[*].nodePort 2>/dev/null)
dinogun
reviewed
Aug 11, 2023
README.md
Outdated
| ``` | ||
| cd kruize-ui | ||
| ``` | ||
| Kruize UI needs Kruize server running locally in the remote monitoring mode. You can setup Kruize [from here](https://github.com/kruize/kruize-demos/tree/main/remote_monitoring_demo). |
There was a problem hiding this comment.
I think we can get rid of remote monitoring mode as it get confusing for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes to
README.mdto make it consistent with current code changes.