Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hiding vertical ruler to free up horizontal space #11

Closed

Conversation

ben-p-commits
Copy link

Description

Enhancement proposal:

Add a boolean property which allows embedding applications to show/hide the vertical ruler in a way that doesn't leave an empty rectangle onscreen. The STTextView should re-tile() to fix the layout gap.

Demo

(Using CodeEditApp/CodeEdit as the client app)

hide-rulers.mp4

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023

CLA assistant check
All committers have signed the CLA.

@ben-p-commits
Copy link
Author

@krzyzanowskim , review requested! :)

@ben-p-commits
Copy link
Author

@krzyzanowskim - false alarm. CETV team wants to go in another direction.

@ben-p-commits ben-p-commits deleted the rulerview-hide branch January 25, 2023 15:29
@krzyzanowskim
Copy link
Owner

good. that didn't fit in STTextView component responsibility. It's up to the external to manage that

@ben-p-commits
Copy link
Author

ben-p-commits commented Jan 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants