Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fields from ModelMesh logs #150

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

ruivieira
Copy link
Contributor

Payload processor logs display the entirety of the Payload, including metadata and request contents.
This is not necessary at the log level.

@ruivieira ruivieira force-pushed the RHOAIENG-12304-logger branch from 6ae2982 to 7a186a8 Compare September 4, 2024 15:11
@ruivieira ruivieira marked this pull request as draft September 4, 2024 15:12
Signed-off-by: Rui Vieira <ruidevieira@googlemail.com>
Since PayloadContent is not used in the logs, only Payload

Signed-off-by: Rui Vieira <ruidevieira@googlemail.com>
@ruivieira ruivieira force-pushed the RHOAIENG-12304-logger branch from be96ed9 to 182dfa1 Compare September 4, 2024 15:17
@ruivieira ruivieira marked this pull request as ready for review September 4, 2024 15:18
@Jooho Jooho requested review from rafvasq and ckadner September 4, 2024 15:19
@Jooho
Copy link

Jooho commented Sep 4, 2024

/lgtm
It should not print metadata that would contain sensitive information.

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rafvasq rafvasq merged commit 6ea70e2 into kserve:main Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants