-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement editing model servers #16
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markwinter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
/retest |
@markwinter Please rebase to master |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markwinter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Alright then you have to fix the broken tests. |
Can you rebase to master and fix the tests? |
Currently it is not possible to edit existing model servers from the web app.
This PR adds a new edit function that lets the users change the existing YAML.
It uses the k8s
replace_namespaced_custom_object
in the backend.This will resolve #2 because the user can add the
canaryTrafficPercent
and change thestorageUri
@kimwnasptd Can you review this please?