Changed EuiIcon mock to render as span instead of div (elastic#4099)

kshitij86 · Nov 29, 2020 · da850e4 · da850e4
1 parent edeb1ca
commit da850e4
Show file tree

Hide file tree

Showing 78 changed files with 464 additions and 463 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
 - Added `max-width: 100%` to `EuiKeyPadMenu` to allow it to shrink when its container is smaller than its fixed width ([ #4092](https://github.com/elastic/eui/pull/4092))
+- Changed `EuiIcon` test mock to render as `span` instead of `div` ([#4099](https://github.com/elastic/eui/pull/4099))
 
 **Bug fixes**
 

diff --git a/src/components/accordion/__snapshots__/accordion.test.tsx.snap b/src/components/accordion/__snapshots__/accordion.test.tsx.snap
@@ -31,7 +31,7 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
  size="m"
  type="arrowRight"
  >
- <div
+ <span
  className="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  size="m"
@@ -92,7 +92,7 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
  size="m"
  type="arrowRight"
  >
- <div
+ <span
  className="euiAccordion__icon euiAccordion__icon-isOpen"
  data-euiicon-type="arrowRight"
  size="m"
@@ -141,7 +141,7 @@ exports[`EuiAccordion is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -217,7 +217,7 @@ exports[`EuiAccordion props arrowDisplay right is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -261,7 +261,7 @@ exports[`EuiAccordion props buttonContent is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -305,7 +305,7 @@ exports[`EuiAccordion props buttonContentClassName is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -345,7 +345,7 @@ exports[`EuiAccordion props extraAction is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -392,7 +392,7 @@ exports[`EuiAccordion props forceState is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -436,7 +436,7 @@ exports[`EuiAccordion props initialIsOpen is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon euiAccordion__icon-isOpen"
  data-euiicon-type="arrowRight"
  />
@@ -480,7 +480,7 @@ exports[`EuiAccordion props isLoading is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />
@@ -531,7 +531,7 @@ exports[`EuiAccordion props isLoadingMessage is rendered 1`] = `
  <span
  class="euiAccordion__iconWrapper"
  >
- <div
+ <span
  class="euiAccordion__icon"
  data-euiicon-type="arrowRight"
  />

diff --git a/src/components/badge/__snapshots__/badge.test.tsx.snap b/src/components/badge/__snapshots__/badge.test.tsx.snap
@@ -307,7 +307,7 @@ exports[`EuiBadge props iconSide left is rendered 1`] = `
  >
  Content
  </span>
- <div
+ <span
  class="euiBadge__icon"
  data-euiicon-type="user"
  />
@@ -328,7 +328,7 @@ exports[`EuiBadge props iconSide right is rendered 1`] = `
  >
  Content
  </span>
- <div
+ <span
  class="euiBadge__icon"
  data-euiicon-type="user"
  />
@@ -349,7 +349,7 @@ exports[`EuiBadge props iconType is rendered 1`] = `
  >
  Content
  </span>
- <div
+ <span
  class="euiBadge__icon"
  data-euiicon-type="user"
  />

diff --git a/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap b/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap
@@ -17,7 +17,7 @@ exports[`CollapsedItemActions render 1`] = `
  data-test-subj="euiCollapsedItemActionsButton"
  type="button"
  >
- <div
+ <span
  aria-hidden="true"
  class="euiButtonIcon__icon"
  data-euiicon-type="boxesHorizontal"

diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -406,7 +406,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
  size="m"
  type="arrowDown"
  >
- <div
+ <span
  className="euiButtonContent__icon"
  data-euiicon-type="arrowDown"
  size="m"
@@ -486,7 +486,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
  size="m"
  type="arrowLeft"
  >
- <div
+ <span
  aria-hidden="true"
  className="euiButtonIcon__icon"
  data-euiicon-type="arrowLeft"
@@ -698,7 +698,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
  size="m"
  type="arrowRight"
  >
- <div
+ <span
  aria-hidden="true"
  className="euiButtonIcon__icon"
  data-euiicon-type="arrowRight"

diff --git a/src/components/breadcrumbs/__snapshots__/breadcrumbs.test.tsx.snap b/src/components/breadcrumbs/__snapshots__/breadcrumbs.test.tsx.snap
@@ -39,7 +39,7 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>
@@ -174,7 +174,7 @@ exports[`EuiBreadcrumbs props max renders 1 item 1`] = `
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>
@@ -310,7 +310,7 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>
@@ -385,7 +385,7 @@ exports[`EuiBreadcrumbs props responsive is rendered as false 1`] = `
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>
@@ -440,7 +440,7 @@ exports[`EuiBreadcrumbs props responsive is rendered with custom breakpoints 1`]
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>
@@ -496,7 +496,7 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
  type="button"
  >
  … 
- <div
+ <span
  data-euiicon-type="arrowDown"
  />
  </button>

diff --git a/src/components/button/__snapshots__/button.test.tsx.snap b/src/components/button/__snapshots__/button.test.tsx.snap
@@ -183,7 +183,7 @@ exports[`EuiButton props iconSide left is rendered 1`] = `
  <span
  class="euiButtonContent euiButton__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />
@@ -204,7 +204,7 @@ exports[`EuiButton props iconSide right is rendered 1`] = `
  <span
  class="euiButtonContent euiButtonContent--iconRight euiButton__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />
@@ -225,7 +225,7 @@ exports[`EuiButton props iconType is rendered 1`] = `
  <span
  class="euiButtonContent euiButton__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />

diff --git a/src/components/button/__snapshots__/button_content.test.tsx.snap b/src/components/button/__snapshots__/button_content.test.tsx.snap
@@ -24,7 +24,7 @@ exports[`EuiButtonContent props iconSide is rendered 1`] = `
 <span
  class="euiButtonContent euiButtonContent--iconRight"
 >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="bolt"
  />
@@ -36,7 +36,7 @@ exports[`EuiButtonContent props iconType is rendered 1`] = `
 <span
  class="euiButtonContent"
 >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="bolt"
  />

diff --git a/src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap b/src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap
@@ -183,7 +183,7 @@ exports[`EuiButtonEmpty props iconSide left is rendered 1`] = `
  <span
  class="euiButtonContent euiButtonEmpty__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />
@@ -204,7 +204,7 @@ exports[`EuiButtonEmpty props iconSide right is rendered 1`] = `
  <span
  class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />
@@ -225,7 +225,7 @@ exports[`EuiButtonEmpty props iconType is rendered 1`] = `
  <span
  class="euiButtonContent euiButtonEmpty__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="user"
  />

diff --git a/src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap b/src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap
@@ -97,7 +97,7 @@ exports[`EuiButtonIcon props iconType is rendered 1`] = `
  class="euiButtonIcon euiButtonIcon--primary"
  type="button"
 >
- <div
+ <span
  aria-hidden="true"
  class="euiButtonIcon__icon"
  data-euiicon-type="user"

diff --git a/src/components/card/__snapshots__/card.test.tsx.snap b/src/components/card/__snapshots__/card.test.tsx.snap
@@ -218,7 +218,7 @@ exports[`EuiCard props icon 1`] = `
  <div
  class="euiCard__top"
  >
- <div
+ <span
  class="myIconClass euiCard__icon"
  data-euiicon-type="apmApp"
  />

diff --git a/src/components/card/__snapshots__/card_select.test.tsx.snap b/src/components/card/__snapshots__/card_select.test.tsx.snap
@@ -89,7 +89,7 @@ exports[`EuiCardSelect props isSelected 1`] = `
  <span
  class="euiButtonContent euiButtonEmpty__content"
  >
- <div
+ <span
  class="euiButtonContent__icon"
  data-euiicon-type="check"
  />

diff --git a/src/components/code/__snapshots__/code_block.test.tsx.snap b/src/components/code/__snapshots__/code_block.test.tsx.snap
@@ -105,7 +105,7 @@ console.log(some);
  class="euiButtonIcon euiButtonIcon--text"
  type="button"
  >
- <div
+ <span
  aria-hidden="true"
  class="euiButtonIcon__icon"
  data-euiicon-type="copy"
@@ -158,7 +158,7 @@ console.log(some);
  class="euiButtonIcon euiButtonIcon--text euiCodeBlock__fullScreenButton"
  type="button"
  >
- <div
+ <span
  aria-hidden="true"
  class="euiButtonIcon__icon"
  data-euiicon-type="fullScreen"