Merge branch 'master' into fix-iceberg-metadata-parsing

kssenii · Oct 15, 2023 · 2015a0f · 2015a0f
2 parents f3056b1 + 0cab773
commit 2015a0f
Show file tree

Hide file tree

Showing 1,030 changed files with 35,625 additions and 30,147 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -28,7 +28,6 @@ Checks: '*,
     -bugprone-not-null-terminated-result,
     -bugprone-reserved-identifier, # useful but too slow, TODO retry when https://reviews.llvm.org/rG1c282052624f9d0bd273bde0b47b30c96699c6c7 is merged
     -bugprone-unchecked-optional-access,
-    -bugprone-*, -- category temporarily disabled because some check(s) in it are slow
 
     -cert-dcl16-c,
     -cert-dcl37-c,
@@ -39,40 +38,9 @@ Checks: '*,
     -cert-oop54-cpp,
     -cert-oop57-cpp,
 
-    -clang-analyzer-optin.performance.Padding,
-    -clang-analyzer-optin.portability.UnixAPI,
-    -clang-analyzer-security.insecureAPI.bzero,
-    -clang-analyzer-security.insecureAPI.strcpy,
-    -clang-analyzer-*, -- category temporarily disabled because some check(s) in it are slow
-
-    -cppcoreguidelines-avoid-c-arrays,
-    -cppcoreguidelines-avoid-const-or-ref-data-members,
-    -cppcoreguidelines-avoid-do-while,
-    -cppcoreguidelines-avoid-goto,
-    -cppcoreguidelines-avoid-magic-numbers,
-    -cppcoreguidelines-avoid-non-const-global-variables,
-    -cppcoreguidelines-explicit-virtual-functions,
-    -cppcoreguidelines-init-variables,
-    -cppcoreguidelines-interfaces-global-init,
-    -cppcoreguidelines-macro-usage,
-    -cppcoreguidelines-narrowing-conversions,
-    -cppcoreguidelines-no-malloc,
-    -cppcoreguidelines-non-private-member-variables-in-classes,
-    -cppcoreguidelines-owning-memory,
-    -cppcoreguidelines-prefer-member-initializer,
-    -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-    -cppcoreguidelines-pro-bounds-constant-array-index,
-    -cppcoreguidelines-pro-bounds-pointer-arithmetic,
-    -cppcoreguidelines-pro-type-const-cast,
-    -cppcoreguidelines-pro-type-cstyle-cast,
-    -cppcoreguidelines-pro-type-member-init,
-    -cppcoreguidelines-pro-type-reinterpret-cast,
-    -cppcoreguidelines-pro-type-static-cast-downcast,
-    -cppcoreguidelines-pro-type-union-access,
-    -cppcoreguidelines-pro-type-vararg,
-    -cppcoreguidelines-slicing,
-    -cppcoreguidelines-special-member-functions,
-    -cppcoreguidelines-*, -- category temporarily disabled because some check(s) in it are slow
+    -clang-analyzer-unix.Malloc,
+
+    -cppcoreguidelines-*, # impractical in a codebase as large as ClickHouse, also slow
 
     -darwin-*,
 
@@ -84,7 +52,6 @@ Checks: '*,
     -google-readability-function-size,
     -google-readability-namespace-comments,
     -google-readability-todo,
-    -google-upgrade-googletest-case,
 
     -hicpp-avoid-c-arrays,
     -hicpp-avoid-goto,

diff --git a/.github/workflows/backport_branches.yml b/.github/workflows/backport_branches.yml
@@ -399,6 +399,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"
@@ -441,6 +448,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"

diff --git a/.github/workflows/docs_check.yml b/.github/workflows/docs_check.yml
@@ -17,6 +17,7 @@ on:  # yamllint disable-line rule:truthy
       - 'docker/docs/**'
       - 'docs/**'
       - 'utils/check-style/aspell-ignore/**'
+      - 'tests/ci/docs_check.py'
 jobs:
   CheckLabels:
     runs-on: [self-hosted, style-checker]

diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -581,6 +581,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"
@@ -707,6 +714,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -17,6 +17,7 @@ on:  # yamllint disable-line rule:truthy
       - 'docker/docs/**'
       - 'docs/**'
       - 'utils/check-style/aspell-ignore/**'
+      - 'tests/ci/docs_check.py'
 ##########################################################################################
 ##################################### SMALL CHECKS #######################################
 ##########################################################################################
@@ -646,6 +647,13 @@ jobs:
         with:
           clear-repository: true
           submodules: true
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"
@@ -769,6 +777,13 @@ jobs:
         with:
           clear-repository: true
           submodules: true
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"

diff --git a/.github/workflows/release_branches.yml b/.github/workflows/release_branches.yml
@@ -456,6 +456,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"
@@ -498,6 +505,13 @@ jobs:
           clear-repository: true
           submodules: true
           fetch-depth: 0 # otherwise we will have no info about contributors
+      - name: Apply sparse checkout for contrib # in order to check that it doesn't break build
+        run: |
+          rm -rf "$GITHUB_WORKSPACE/contrib" && echo 'removed'
+          git -C "$GITHUB_WORKSPACE" checkout .  && echo 'restored'
+          "$GITHUB_WORKSPACE/contrib/update-submodules.sh" && echo 'OK'
+          du -hs "$GITHUB_WORKSPACE/contrib" ||:
+          find "$GITHUB_WORKSPACE/contrib" -type f | wc -l ||:
       - name: Build
         run: |
           sudo rm -fr "$TEMP_PATH"

diff --git a/.gitmodules b/.gitmodules
@@ -257,6 +257,9 @@
 [submodule "contrib/corrosion"]
 	path = contrib/corrosion
 	url = https://github.com/corrosion-rs/corrosion
+[submodule "contrib/libssh"]
+	path = contrib/libssh
+	url = https://github.com/ClickHouse/libssh.git
 [submodule "contrib/morton-nd"]
 	path = contrib/morton-nd
 	url = https://github.com/morton-nd/morton-nd