Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Publish schematools-cli crate #104

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Dec 17, 2023

No description provided.

@jayvdb jayvdb changed the title Publish schematools-cli crate feat: Publish schematools-cli crate Dec 17, 2023
@kstasik
Copy link
Owner

kstasik commented Dec 17, 2023

Please make sure your commits follow conventional commits standards. There is an automatic versioning of packages installed on this repo. If you merge it without correct commit name ci/cd pipelines will fail on main branch.

https://github.com/kstasik/schema-tools/blob/master/.cz.toml

https://github.com/commitizen/cz-cli

@jayvdb
Copy link
Collaborator Author

jayvdb commented Dec 17, 2023

We should add some CI to check the commit messages in the PR.

I'll fixup #105 first

@jayvdb jayvdb force-pushed the cli-crate branch 3 times, most recently from e69b3af to f8b314e Compare December 17, 2023 10:54
@@ -25,4 +25,4 @@ clap = { version = "4.4", features = ["derive"] }
env_logger = "0.10"
sha2 = "0.10"

schematools = { path = "../schematools" }
schematools = { version = "0.17", path = "../schematools" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this isnt going to work perfectly with the automatic release versioning.

I believe it should be fine for most cases, as this sets the lower compatible version, but it will require manually bumping for any major release. We can probably organise some automated changing of this version also.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the line to (full semversion):

schematools = { version = "0.17.1", path = "../schematools" }

You can add to https://github.com/kstasik/schema-tools/blob/master/.cz.toml#L6C50-L6C50:

    "crates/cli/Cargo.toml:^schematools",

If i remember correctly it uses regexp to find proper line and replaces old sem version to new one.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've installed cz and confirmed that worked.

@kstasik kstasik merged commit 14a09ad into kstasik:master Dec 17, 2023
8 checks passed
@jayvdb jayvdb deleted the cli-crate branch January 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants