-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Publish schematools-cli crate #104
Conversation
Please make sure your commits follow conventional commits standards. There is an automatic versioning of packages installed on this repo. If you merge it without correct commit name ci/cd pipelines will fail on main branch. https://github.com/kstasik/schema-tools/blob/master/.cz.toml |
We should add some CI to check the commit messages in the PR. I'll fixup #105 first |
e69b3af
to
f8b314e
Compare
crates/cli/Cargo.toml
Outdated
@@ -25,4 +25,4 @@ clap = { version = "4.4", features = ["derive"] } | |||
env_logger = "0.10" | |||
sha2 = "0.10" | |||
|
|||
schematools = { path = "../schematools" } | |||
schematools = { version = "0.17", path = "../schematools" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this isnt going to work perfectly with the automatic release versioning.
I believe it should be fine for most cases, as this sets the lower compatible version, but it will require manually bumping for any major release. We can probably organise some automated changing of this version also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change the line to (full semversion):
schematools = { version = "0.17.1", path = "../schematools" }
You can add to https://github.com/kstasik/schema-tools/blob/master/.cz.toml#L6C50-L6C50:
"crates/cli/Cargo.toml:^schematools",
If i remember correctly it uses regexp to find proper line and replaces old sem version to new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've installed cz and confirmed that worked.
No description provided.