Remove KSCrash symbols from user-reported exceptions #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
approved these changes
Nov 3, 2024
| #define HDR_KSCompilerDefines_h | ||
|
|
||
| /// Disables optimisations to ensure a function remains in stacktrace. | ||
| /// Usually used in pair with `KS_THWART_TAIL_CALL_OPTIMISATION`. |
There was a problem hiding this comment.
Why is KS_THWART_TAIL_CALL_OPTIMISATION insufficient on its own?
There was a problem hiding this comment.
It should be enough, but function annotation is a bit more readable (IMO).
bamx23
force-pushed
the
fix-callstack-for-user-reports
branch
from
dc4ec33
to
0236bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on #588 to fix the content of crashed threads in user reports (both API methods).