Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"예약하기" 버튼 클릭시 "Uncaught ReferenceError: showModalDialog is not defined" 에러 발생 #1

Closed
gubug0 opened this issue Feb 3, 2016 · 1 comment · Fixed by #3 or #4
Assignees
Labels

Comments

@gubug0
Copy link
Contributor

gubug0 commented Feb 3, 2016

Chrome Browser에서 좌석 조회 후, "예약하기"버튼을 누르면,
개발자 console에 "Uncaught ReferenceError: showModalDialog is not defined" 에러가 발생하면서 아무 동작을 하지 않습니다.

정상 동작을 위해서는 showModalDialog function 구현체가 필요할 것 같습니다.

@kswchoo kswchoo self-assigned this Feb 3, 2016
@kswchoo kswchoo added the bug label Feb 3, 2016
@gubug0
Copy link
Contributor Author

gubug0 commented Feb 3, 2016

inject.js

window.showModalDialog = window.showModalDialog || function(url, arg, opt) {
    window.open(url, arg, opt);
}; 

코드 추가해서 해결 가능한 것으로 보이네요.

@kswchoo kswchoo closed this as completed in #3 Feb 3, 2016
gubug0 added a commit to gubug0/korailmacro that referenced this issue Feb 3, 2016
… 동작하지 않는 문제 해결

* 직접 "예약하기" 버튼을 클릭하는 경우 정상 동작하지만, 메크로로 예약하는 경우 "showModalDialog is not
defined" 에러 발생 문제 해결
* 메크로 동작시 confirmation alert 이 발생하면서 메크로 동작이 멈추는 문제 해결
resolve kswchoo#1, kswchoo#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment