Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(annotable): remove unfinished __coerce__ implementation and add tests #24

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

cpcloud
Copy link
Collaborator

@cpcloud cpcloud commented Sep 1, 2024

Closes #23.

@cpcloud cpcloud requested a review from kszucs September 1, 2024 15:41
@cpcloud
Copy link
Collaborator Author

cpcloud commented Sep 1, 2024

I guess nested Annotable isn't supported?

@cpcloud
Copy link
Collaborator Author

cpcloud commented Sep 1, 2024

Ah, works if the classes are defined top-level.

@kszucs
Copy link
Owner

kszucs commented Sep 1, 2024

Yes, that is another issue. Please update the test case to define the classes at the module level then we can merge it.

@cpcloud cpcloud merged commit 458b36f into kszucs:main Sep 1, 2024
15 checks passed
@cpcloud cpcloud deleted the remove-coerce-method branch September 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't nest annotable objects with defaults
2 participants