Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI detection issue #40

Merged
merged 5 commits into from
May 10, 2015
Merged

Conversation

kevin-lee
Copy link
Contributor

This fixes #15.
It still requires some extra step (i.e. adding CI_NAME=travis-ci) yet it is easy and simple enough.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 80.42% when pulling b4878f5 on Kevin-Lee:travis-ci-detection-issue into 0feac4d on kt3k:master.

@kevin-lee
Copy link
Contributor Author

I've just uploaded the fixed one to my bintray repo and it works. Now I can see Coveralls's test coverage results.

If you want to test it, add the following info accordingly in your build.gradle.

buildscript {
  repositories {
    jcenter()
    mavenCentral()
    maven {
      url  "http://dl.bintray.com/kevinlee/maven"
    }
  }
  dependencies {
    classpath 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.3.2'
  }
}

I'll add tests for my changes soon.

@kevin-lee
Copy link
Contributor Author

Done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 80.42% when pulling 7f548a1 on Kevin-Lee:travis-ci-detection-issue into 0feac4d on kt3k:master.

@kt3k
Copy link
Owner

kt3k commented May 10, 2015

Thank you very much! Nice documentation 👍

kt3k added a commit that referenced this pull request May 10, 2015
@kt3k kt3k merged commit 391c594 into kt3k:master May 10, 2015
@kt3k
Copy link
Owner

kt3k commented May 10, 2015

Uploaded this version as v2.4.0 (maven-central & bintray).

https://bintray.com/kt3k/gradle-plugins/coveralls-gradle-plugin/2.4.0/view

@kevin-lee
Copy link
Contributor Author

@kt3k That's good. 👍 Thank you! I've just tested, and it works well. I'll remove the one I uploaded to my bintray for testing.

@kt3k
Copy link
Owner

kt3k commented May 10, 2015

Thanks for testing! 😄

@kevin-lee kevin-lee deleted the travis-ci-detection-issue branch December 1, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better detection of travis-ci vs pro
3 participants