Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typing.re import #2788

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Replace typing.re import #2788

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a81d8d5
Replace typing.re import
srittau May 18, 2022
8ae007d
Add type argument to Pattern
srittau May 18, 2022
914e048
Add a type ignore
srittau May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions netmiko/snmp_autodetect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
Note, pysnmp is a required dependency for SNMPDetect and is intentionally not included in
netmiko requirements. So installation of pysnmp might be required.
"""
from typing import Optional, Dict
from typing.re import Pattern
from typing import Optional, Dict, Pattern
import re

try:
Expand Down Expand Up @@ -334,7 +333,7 @@ def autodetect(self) -> Optional[str]:
for entry in snmp_mapper_list:
for device_type, v in entry.items():
oid: str = v["oid"] # type: ignore
regex: Pattern = v["expr"]
regex: Pattern[str] = v["expr"] # type: ignore

# Used cache data if we already queryied this OID
if self._response_cache.get(oid):
Expand Down