-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Cloud fortigate driver for non-global commands #3394
base: develop
Are you sure you want to change the base?
Conversation
Created folder for fortinet-ibmcloud
Updated Linters and cache
@ktbyers Can you check this again after the changes I made? |
@SaneiSaya So you are trying to get the fortinet driver to work, but without needing any |
Yes, we don't have access to run any global commands as we only have VDOM
access.
…On Fri, May 3, 2024 at 6:08 PM Kirk Byers ***@***.***> wrote:
@SaneiSaya <https://github.com/SaneiSaya> So you are trying to get the
fortinet driver to work, but without needing any global commands--correct?
—
Reply to this email directly, view it on GitHub
<#3394 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJLQ3JX3JTF3UNF3SUZJJLZAQRHLAVCNFSM6AAAAABEF3KQFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTHEYDCOJQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@SaneiSaya Sorry for very delayed response--is this still an issue that you are looking to fix/work on? |
Yes, I would still like to get this in.
…On Tue, Jan 21, 2025 at 2:51 PM Kirk Byers ***@***.***> wrote:
@SaneiSaya <https://github.com/SaneiSaya> Sorry for very delayed
response--is this still an issue that you are looking to fix/work on?
—
Reply to this email directly, view it on GitHub
<#3394 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJLQ3OIEPG6UH5GAEC2PUL2L26ORAVCNFSM6AAAAABUBY3IUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVHAYTENZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
return result_mode | ||
return "more" | ||
else: | ||
return "more" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused as to why you made this change? Why did you make any changes to the non-IBM driver?
return "" | ||
|
||
if self._vdoms: | ||
output += self._config_global() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand this? I thought your purpose was to get rid of config global
, but it still does config global
(depending on VDoms)?
How do you want this to behave? So we can't execute
So one working option is for the end-user to set an environment variable named In other words, the end-user configure the device so there is no output paging and then set the above environment variable. Once this, happens we can bypass all of the above. I don't see how your current PR fixes the original issue you were running into? Regards, Kirk |
Adding a driver that will work with IBM Cloud 1500D as users are restricted and not able to run global commands. This driver allows non-global commands to be run