Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Palo Alto Log Collector Compatibility #3535

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

opachano
Copy link

  • Updates self.write_channel and _test_channel_read in paloalto_panos.py for Palo Alto Log Collector compatibility.

Context: Palo Alto Devices set up as log collectors have no valid "show admins' command. So this module will always fail for these devices. "show system info" is available for firewall and log collector setups.

@opachano
Copy link
Author

@ktbyers Related to #3387 and #2934 on 2934 you mentioned you were looking for a PR to implement this change. This is that PR.

@opachano
Copy link
Author

opachano commented Dec 2, 2024

@ktbyers Please let me know if you need me to provide more information/context around this fix or if you have any comments for this PR, I would be more that happy to implement any suggestions. I have been using a patched version of this module with these changes included and it has been working without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant