Adding support for corvil

[zenonymous]

Show

commands = ["show version”]

Output

Corvil CNE Appliance software: Version 10.0.1 (10.0.1.20732-GA.296474-64bit Thu
17 Oct 2024)
CorvilMeter software: CDK_3_0_BUILD_73 (conf May 30 03:18:34 2024)
Application Recognition Module: ARM v6.86 (full)

Config

config_commands = [
‘subnet-group bla’,
‘description “Azure ip space”’,
‘subnet 1.2.3.45/32’,
‘end’
}

Output

switch(config)$ subnet-group bla
Created: subnet-group bla
switch(config-subnet-group)$ description "Azure ip space"
switch(config-subnet-group)$ subnet 1.2.3.4/32
switch(config-subnet-group)$ end
switch(config)$

[ktbyers]

Is it possible for you to run these tests and post the output here:

py.test -v test_netmiko_show.py --test_device cisco881  
py.test -v test_netmiko_config.py --test_device cisco881

See:

https://github.com/ktbyers/netmiko/blob/develop/TESTING.md

[ktbyers]

Need to fix linting issue, just run black . at the base of the repository:

Linting errors:

Run poetry run black --check .
would reformat /home/runner/work/netmiko/netmiko/netmiko/corvil/__init__.py
would reformat /home/runner/work/netmiko/netmiko/netmiko/corvil/corvilcne_ssh.py
would reformat /home/runner/work/netmiko/netmiko/netmiko/gigamon/__init__.py
would reformat /home/runner/work/netmiko/netmiko/netmiko/gigamon/gigamonvue_ssh.py

[ktbyers]

Also you included your Gigamon changes here--did you intend to include these in this PR?

[zenonymous]

Hi Kirk, Thank you for your message, I was trying to do the first PR for only one vendor and when thats all ok I will know exactly how to do the others as well: sorry if the Gigamon changes have been already present, I will start again and fix the linting issue and try to run the py.test and post the output from that. Some time ago my colleague committed a module I made ( #3393) and I just tried to replicate that regarding the comment in the PR, now I understand there's more to it. Kind regards, Jeroen Bosch

…

On Sun, Dec 1, 2024 at 10:33 PM Kirk Byers ***@***.***> wrote: Also you included your Gigamon changes here--did you intend to include these in this PR? — Reply to this email directly, view it on GitHub <#3541 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOYNRQUPV636SRY247RUZL2DN6DLAVCNFSM6AAAAABSXFCJ7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGI3DANRRGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ktbyers]

@zenonymous Just let me know if you have questions on the PR or the testing process.

Regards, Kirk