WIP: Add node 10 support #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should demonstrate the error in ktmud#69.
Issues still remain; see ktmud#69 (comment)
So we can see which version pass and which fail.
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 196 196
Branches 33 36 +3
=========================================
Hits 196 196 Continue to review full report at Codecov.
|
|
@ktmud why close this while node 10 is neither supported nor documented as not supported? |
|
I closed all issues because I've removing renovate integration (and use GitHub's built-in dependabot instead). I'll keep working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to close #69 but doesn't quite do it yet. See CI results, and #69 (comment).
Opening in WIP state for demonstration/troubleshooting purposes.