Skip to content
This repository has been archived by the owner on Jul 9, 2022. It is now read-only.

Add Github workflows #25

Closed
wants to merge 7 commits into from
Closed

Add Github workflows #25

wants to merge 7 commits into from

Conversation

ktmud
Copy link
Owner

@ktmud ktmud commented Apr 7, 2020

CATEGORY

  • Build / Development Environment

SUMMARY

Test adding GitHub Actions per discussion in apache#9481

Everything is sequential at the moment. Will see if it's possible to use Actions Toolkit to speed up things later.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Make sure CI check pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

MYSQL_USER: superset
MYSQL_DATABASE: superset
MYSQL_PASSWORD: superset
steps:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this will execute all tasks sequentially.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's one of the limitations. GitHub Actions only supports workflow level parallelization, which means each workflow would have to run the same build process again and have some duplicate code. Good news is there is cache at the workflow level, so the only thing we need to look at is how to make the build code reusable.

@ktmud ktmud force-pushed the github-actions branch 4 times, most recently from 2da26a2 to 81a7bf0 Compare April 8, 2020 01:18
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #25 into master will increase coverage by 10.56%.
The diff coverage is 71.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
+ Coverage   58.77%   69.33%   +10.56%     
===========================================
  Files         385      565      +180     
  Lines       12239    27850    +15611     
  Branches     3022     3025        +3     
===========================================
+ Hits         7193    19310    +12117     
- Misses       4862     8355     +3493     
- Partials      184      185        +1     
Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.48% <0.00%> (-1.49%) ⬇️
...erset-frontend/src/SqlLab/components/ResultSet.jsx 71.68% <0.00%> (-4.02%) ⬇️
...ontend/src/explore/controlPanels/Shared_DeckGL.jsx 0.00% <0.00%> (ø)
superset/connectors/sqla/models.py 85.38% <ø> (ø)
superset/models/sql_lab.py 91.96% <ø> (ø)
superset/security/manager.py 89.11% <ø> (ø)
...src/SqlLab/components/ExploreCtasResultsButton.jsx 13.33% <13.33%> (ø)
superset/connectors/sqla/views.py 76.98% <33.33%> (ø)
superset/views/base.py 72.35% <72.22%> (ø)
superset/common/query_object.py 95.83% <88.88%> (ø)
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39e78f...35d0f79. Read the comment docs.

@ktmud ktmud force-pushed the github-actions branch 9 times, most recently from ab89723 to d6290d7 Compare April 8, 2020 09:26
@ktmud ktmud force-pushed the github-actions branch 2 times, most recently from dab4564 to a0393d8 Compare April 9, 2020 05:52
@ktmud ktmud changed the title Add Github workflows (apache/incubator-superset#9481) Add Github workflows Apr 9, 2020
@ktmud ktmud force-pushed the github-actions branch 4 times, most recently from 04fd288 to fd5c4ec Compare April 9, 2020 07:39
@cypress
Copy link

cypress bot commented Apr 9, 2020



Test summary

28 0 10 0


Run details

Project Superset
Status Passed
Commit e2697e9417 ℹ️
Started Apr 9, 2020 10:00 PM
Ended Apr 9, 2020 10:02 PM
Duration 02:05 💡
OS Linux Ubuntu Linux - 18.04
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ktmud ktmud force-pushed the github-actions branch 5 times, most recently from 4c55a1f to f8f07cc Compare April 9, 2020 18:27
@ktmud ktmud force-pushed the github-actions branch 8 times, most recently from 0e3b695 to 07876ff Compare April 11, 2020 10:54
@ktmud ktmud force-pushed the github-actions branch 17 times, most recently from d43f5d9 to 33a4e8a Compare April 12, 2020 06:39
as replacement to Travis CI.
@ktmud ktmud closed this Apr 12, 2020
@ktmud ktmud deleted the github-actions branch April 12, 2020 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants