Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast compilation and jvmTest check for PRs #4042

Closed
wants to merge 3 commits into from
Closed

Conversation

e5l
Copy link
Member

@e5l e5l commented May 17, 2024

Add fast check for compilation and jvmTests

@e5l e5l requested a review from Mr3zee May 17, 2024 08:27
@e5l e5l self-assigned this May 17, 2024
@Mr3zee
Copy link
Collaborator

Mr3zee commented May 17, 2024

@e5l I'm not an expert in GH Actions, but maybe the error will go away when using this https://github.com/gradle/gradle-build-action ?

@hfhbd
Copy link
Contributor

hfhbd commented May 30, 2024

It is the correct action, but using the argument syntax is deprecated. Anyway, this is unrelated to the actual compiling failure, which was caused by a wrong commit: I used the main branch and it did work: hfhbd#91
BTW you can also remove the wrapper validation file and just enable: validate-wrappers: true. Alternatively, I can create the PR.

@e5l
Copy link
Member Author

e5l commented Jun 19, 2024

@hfhbd, thanks. It helped.

@Mr3zee, fixed. Please check.

Mr3zee
Mr3zee previously approved these changes Jun 19, 2024
@hfhbd
Copy link
Contributor

hfhbd commented Jun 19, 2024

But keep in mind, the build doesn't fail if a jvm test failed, 1 test failed:

Gradle Test Executor 57

io.ktor.tests.jte.JteTest$StringTemplateResolver requires JVM 17 because gg/jte/CodeResolver is compiled with JDK 17.

@Mr3zee Mr3zee dismissed their stale review June 19, 2024 15:54

Nevermind, checks don't fail on failing tests as pointed out above

@e5l
Copy link
Member Author

e5l commented Jun 21, 2024

Yep, let me check if we can bring test results to the UI

@e5l e5l marked this pull request as draft June 21, 2024 06:56
@e5l e5l closed this Jul 11, 2024
@e5l e5l deleted the e5l/add-fast-pr-check branch September 25, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants