-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for kotlinx-io byte channel handling #4070
Conversation
The tests pass! Still need to address the common target failing in the allocation tests build and some styling, so it seems. |
128bcb3
to
28cd246
Compare
8384f76
to
d325c82
Compare
See this for the allocation tests fix ktorio/ktor-benchmarks#19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except some failing tests (eadChannel should not lock file pre read()[jvm]) on windows.
Please also update an API dump
Seems the allocation test results warrant some investigation... Netty
CIO
|
Yep, we are. Some places (like LookAheadSession.kt) we can deprecate and replace with a different API |
e025845
to
3fc9b7e
Compare
I'll merge what I've got for now since the memory footprint testing will take some time to resolve. |
Addressing comments and CI problems in #4032