Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchosDeviceArm64 target with yaml workaround #4191

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Aug 4, 2024

fixes KTOR-6368 by adding workaround for yaml module and removing unnecessary dependencies on that module in tests.

yamlkt doesn't support the target yet. There is an open PR, but there are some problems with integration.

After that PR will be merged, dependency could be updated and hack in NativeUtils could be removed.

@e5l e5l self-requested a review August 5, 2024 09:48
@e5l
Copy link
Member

e5l commented Aug 5, 2024

@whyoleg, could you please rebase?

@e5l e5l merged commit 78f69ce into ktorio:main Aug 5, 2024
1 of 16 checks passed
@whyoleg whyoleg deleted the yaml-workaround branch August 5, 2024 10:12
@lukeleleh
Copy link

Hi! Thanks for the workaround 🙌

With the PR now merged, do you have any idea when a new version of Ktor will be released that includes it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants