Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7278: fix accept header evaluation #4264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anton-erofeev
Copy link
Contributor

Subsystem
Server, ktor-server-core

Motivation
https://youtrack.jetbrains.com/issue/KTOR-7278

Solution
fixed Content-Type header evaluation

Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osipxd
Copy link
Member

osipxd commented Sep 9, 2024

Please check the CI

It seems like our CI is not reachable for community, so here are the logs:

io.ktor.tests.server.routing.RoutingProcessingTest
  testAcceptHeaderProcessing()[jvm] - FAILED

org.opentest4j.AssertionFailedError: expected: <OK> but was: <>
  at app//kotlin.test.junit5.JUnit5Asserter.assertEquals(JUnitSupport.kt:32)
  at app//kotlin.test.AssertionsKt__AssertionsKt.assertEquals(Assertions.kt:63)
  at app//kotlin.test.AssertionsKt.assertEquals(Unknown Source)
  at app//kotlin.test.AssertionsKt__AssertionsKt.assertEquals$default(Assertions.kt:62)
  at app//kotlin.test.AssertionsKt.assertEquals$default(Unknown Source)
  at app//io.ktor.tests.server.routing.RoutingProcessingTest$testAcceptHeaderProcessing$1.invokeSuspend(RoutingProcessingTest.kt:496)
  at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
  at app//kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
  at app//kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:111)
  at app//kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:99)
  at app//kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
  at app//kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:811)
  at app//kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:715)
  at app//kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:702)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants