Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-7410: add about URL parsing #4282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

KTOR-7410: add about URL parsing #4282

wants to merge 2 commits into from

Conversation

anton-erofeev
Copy link
Contributor

Subsystem
ktor-http

Motivation
https://youtrack.jetbrains.com/issue/KTOR-7410

Solution
Added processing of about:blank and other about: urls

@bjhham
Copy link
Contributor

bjhham commented Sep 11, 2024

Seems to be failing on JS on account of a port creeping in.

AssertionError: Expected <http://localhost/about>, actual <http://localhost:9876/about>

Could you update the assertion?

@anton-erofeev
Copy link
Contributor Author

Could you update the assertion?

@bjhham sure, I updated the assertion, please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhham bjhham bjhham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-erofeev @bjhham