KTOR-7812 Use default JDK for running tests on CI #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
from
689782f
to
462fd68
Compare
|
There seems to be some problems in the TLS package - we got an out-dated ECDH curve You also seem to have unlocked a consistent failure in |
|
Yes, finally these builds against different Java versions found something :) |
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
from
462fd68
to
5749278
Compare
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
from
5749278
to
8210bed
Compare
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
6 times, most recently
from
719000a
to
a623b53
Compare
osipxd
commented
Nov 19, 2024
| @@ -186,7 +186,7 @@ class CookiesIntegrationTests : ClientLoader() { | |||
| } | |||
|
|
|||
| @Test | |||
| fun testCookiesWithWrongValue() = clientTests(listOf("js", "Darwin", "DarwinLegacy", "WinHttp")) { | |||
| fun testCookiesWithWrongValue() = clientTests(listOf("Js", "Darwin", "DarwinLegacy", "WinHttp", "Java")) { | |||
There was a problem hiding this comment.
openjdk/jdk16@1c47244: Java 16 adds validation for header values, so this test doesn't pass on Java engine anymore
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
from
433072c
to
6f9571d
Compare
osipxd
changed the title
Also refactor onlyWithEngine
osipxd
force-pushed
the
osipxd/run-tests-on-target-jvm
branch
from
6f9571d
to
2e4099b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Tests infrastructure
Motivation
KTOR-7812 Use default JDK for running tests on CI
Solution
Use the JDK from
JAVA_HOMEto run tests on CI.It is better to review commit by commit.