KTOR-7682 Fix TestApplication.stop() doesn't stop the application anymore #4534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Test Infrastructure
Motivation
KTOR-7682 TestApplication.stop() doesn't stop the application anymore
Solution
The problem occurs because
TestApplication.client
uses an instance of an application different from the returned byTestApplication
constructor-like function and callsstart()
on it.TestApplication.start()
callsTestApplicationEngine.start()
under the hood which rewritescancellationJob
, so coroutine waiting for cancellation never ends.To fix this problem:
TestApplication
returnapplication
from builder – the same as used in a clientTestApplication
constructor to make builder the only way to getTestApplication
and break circular dependency:TestApplication
->ApplicationTestBuilder
->TestApplication
It is better to review commit-by-commit