KTOR-8045 Fix for NPE race condition in dispose #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
approved these changes
Jan 14, 2025
...ktor-server-double-receive/common/src/io/ktor/server/plugins/doublereceive/ByteArrayCache.kt
Show resolved
Hide resolved
osipxd
force-pushed
the
bjhham/npe-double-receive
branch
from
ade4a8a to
a59f7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server, DoubleReceive
Motivation
KTOR-8045 DoubleReceive: NullPointerException caused by race condition
Solution
Moving the body's discard call outside the coroutine avoids the race condition when dispose is called twice.