Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-8057 Introduce base class for client engine tests #4598

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Jan 13, 2025

Subsystem
Client, Test Infrastructure

Motivation
KTOR-8057 Introduce base class for client tests
KTOR-8058 Don't publish internal test artifacts

Solution

  • Move test infrastructure classes from ktor-client-tests to a new module ktor-client-test-base
  • Add new class ClientEngineTest simplifying testing of client engines, enabling timeouts and retries.
  • Migrate existing client engine tests to the new test infrastructure

It's simpler to review commit by commit

@osipxd osipxd self-assigned this Jan 13, 2025
@osipxd osipxd force-pushed the osipxd/base-client-test branch from d0a7002 to 9de47ec Compare January 13, 2025 16:14
@osipxd osipxd marked this pull request as ready for review January 13, 2025 17:14
@osipxd osipxd force-pushed the osipxd/base-client-test branch from 9de47ec to 4557d90 Compare January 14, 2025 09:23
@osipxd osipxd requested a review from bjhham January 14, 2025 10:02
@osipxd osipxd force-pushed the osipxd/base-client-test branch from 4557d90 to 17eb425 Compare January 14, 2025 10:11
Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, nice job 👍

@osipxd osipxd merged commit c47dfda into main Jan 14, 2025
16 checks passed
@osipxd osipxd deleted the osipxd/base-client-test branch January 14, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants