Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

Follower does not commit entries on receiving heartbeat #33

Open
schuster opened this issue Apr 15, 2015 · 1 comment
Open

Follower does not commit entries on receiving heartbeat #33

schuster opened this issue Apr 15, 2015 · 1 comment
Milestone

Comments

@schuster
Copy link

If no new requests come in for a long time, it might be that the only way a follower knows to commit a request is to do so on a heartbeat message, so the commit logic should happen there, too.

Really, there should be no difference in the processing for heartbeats and non-heartbeats. A heartbeat is just an AppendEntries in which the list of new entries is empty, so an empty list is appended to the log.

@colin-scott
Copy link
Contributor

For what it's worth, I have (non-pull-request-worthy) fix for this issue here:

NetSys/demi-applications@687a244
NetSys/demi-applications@6c81d34

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants