This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Adopt 1-indexed logs. With this change, fix many other dependent issues #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/main/scala/pl/project13/scala/akka/raft/Follower.scala
|
Thanks! Will review tonight. |
|
I think I'll merge and adjust the minor nitpicks I had :) Thanks a lot for these PRs! I'll slowly go through them and add tests in the coming days. |
ktoso
added a commit
that referenced
this pull request
Aug 14, 2015
Adopt 1-indexed logs. With this change, fix many other dependent issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30, #32, #33, #37, #38, #41, #42, #48, #58, #59
I wish I could make this a smaller PR, but all these changes are dependent on 1-indexing.
This almost certainly breaks the existing unit tests -- but I'm fairly confident this is correct -- my fuzz tester hasn't found any safety violations in the last ~8 hours of testing.
Note! There are probably still bugs in ReplicatedLog.scala in the presence of log compaction
For what it's worth, I gave you write access to my akka-raft fork. I'm currently on a deadline, and don't have time to deal with comments, keeping PR branches up-to-date, etc, but I'm happy to answer questions.