-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[retry] Replace termbox to tcell #55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 88.65% 87.10% -1.56%
==========================================
Files 5 5
Lines 485 543 +58
==========================================
+ Hits 430 473 +43
- Misses 40 57 +17
+ Partials 15 13 -2 |
@tjmtmmnk |
It looks like there are conflicts, so can you resolve them? |
2de347c
to
3821bcd
Compare
Of course, any time is ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried another snippet, but it got strange behavior. The second prompt didn't appear.
#46
It seems that PollEvent
is returning nil because the Screen
is finalized in the previous session.
I cloud reproduce the same problem... |
No problem 👍 |
…rmbox-go to gdamore/tcell (ktr0731#47)" This reverts commit f3bcd19. # Conflicts: # go.mod # go.sum
3821bcd
to
5a7ebd0
Compare
Hello, I apologize for the delay. After checking, this problem seems to be caused by a package variable
Therefore, I created I could confirm that this problem was fixed in local. I tried to add test, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Looks good to me, thanks for your continuous contribution!
@@ -68,13 +64,22 @@ type finder struct { | |||
opt *opt | |||
} | |||
|
|||
func newFinder() *finder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
related: #32
Hello.
Finally, tcell announced the fix of lost key problem officially. gdamore/tcell#194 (comment)
So, we can avoid the workaround which causes the cgo problem!
I could confirm that this program work well in local.