-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parentspan #1579
fix parentspan #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @golanha and @yehiyam)
core/api-server/tests/exec-pipelines.js
line 19 at r2 (raw file):
restPath = `${restUrl}/exec/pipelines`; tracer.startSpanOld = tracer.startSpan;
use sinon.spy
core/api-server/tests/exec-pipelines.js
line 156 at r2 (raw file):
}; const response = await request(options); expect(rootSpan).to.eq('abcd');
don't add it here. Create a new test for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @yehiyam)
core/api-server/tests/exec-pipelines.js
line 19 at r2 (raw file):
Previously, yehiyam wrote…
use sinon.spy
Done.
core/api-server/tests/exec-pipelines.js
line 156 at r2 (raw file):
Previously, yehiyam wrote…
don't add it here. Create a new test for this
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @golanha)
* fix parentspan * add unit test * CR Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
* fix parentspan * add unit test * CR Co-authored-by: yehiyam <yehiyam@users.noreply.github.com> .... bump version [skip ci]
This change is