-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph api for pipeline #1591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @golanha)
core/api-server/package.json
line 23 at r1 (raw file):
"@hkube/units-converter": "^1.0.17", "@octokit/rest": "^18.12.0", "clone": "^2.1.2",
This package was last updated 4 years ago.
Why not use lodash.clonedeep?
same for flat
core/api-server/lib/service/pipelines.js
line 65 at r1 (raw file):
const { flowInputMetadata, flowInput, ...restPipeline } = pipeline; const extendedPipeline = await pipelineCreator.buildPipelineOfPipelines(restPipeline);
Dows this cover all relevant pipeline extensions?
Code quote:
getJSONGraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 12 files reviewed, 2 unresolved discussions (waiting on @yehiyam)
core/api-server/package.json
line 23 at r1 (raw file):
Previously, yehiyam wrote…
This package was last updated 4 years ago.
Why not use lodash.clonedeep?same for flat
Done.
core/api-server/lib/service/pipelines.js
line 65 at r1 (raw file):
Previously, yehiyam wrote…
Dows this cover all relevant pipeline extensions?
Same code as the code running in the pipelinedriver minus the special handling of batch and for the task information
/deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @golanha)
* Add graph api * CR .... bump version [skip ci]
* Add graph api * CR .... bump version [skip ci]
This change is