Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph api for pipeline #1591

Merged
merged 2 commits into from
May 22, 2022
Merged

Add graph api for pipeline #1591

merged 2 commits into from
May 22, 2022

Conversation

golanha
Copy link
Member

@golanha golanha commented May 19, 2022

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @golanha)


core/api-server/package.json line 23 at r1 (raw file):

        "@hkube/units-converter": "^1.0.17",
        "@octokit/rest": "^18.12.0",
        "clone": "^2.1.2",

This package was last updated 4 years ago.
Why not use lodash.clonedeep?

same for flat


core/api-server/lib/service/pipelines.js line 65 at r1 (raw file):

        const { flowInputMetadata, flowInput, ...restPipeline } = pipeline;

        const extendedPipeline = await pipelineCreator.buildPipelineOfPipelines(restPipeline);

Dows this cover all relevant pipeline extensions?

Code quote:

getJSONGraph

Copy link
Member Author

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 12 files reviewed, 2 unresolved discussions (waiting on @yehiyam)


core/api-server/package.json line 23 at r1 (raw file):

Previously, yehiyam wrote…

This package was last updated 4 years ago.
Why not use lodash.clonedeep?

same for flat

Done.


core/api-server/lib/service/pipelines.js line 65 at r1 (raw file):

Previously, yehiyam wrote…

Dows this cover all relevant pipeline extensions?

Same code as the code running in the pipelinedriver minus the special handling of batch and for the task information

@golanha golanha requested a review from yehiyam May 22, 2022 06:39
@golanha
Copy link
Member Author

golanha commented May 22, 2022

/deploy

@hkube-ci hkube-ci temporarily deployed to dev May 22, 2022 10:26 Inactive
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @golanha)

@golanha golanha merged commit ef73845 into master May 22, 2022
@golanha golanha deleted the pipeline_graph_api branch May 22, 2022 15:05
hkube-ci pushed a commit that referenced this pull request May 22, 2022
* Add graph api

* CR .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request May 22, 2022
* Add graph api

* CR .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants