Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add errors to version not last #1646

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Conversation

zivglik
Copy link
Contributor

@zivglik zivglik commented Dec 27, 2022

This change is Reviewable

@zivglik
Copy link
Contributor Author

zivglik commented Dec 27, 2022

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev December 27, 2022 10:51 Inactive
@zivglik zivglik requested a review from golanha December 27, 2022 10:51
@zivglik
Copy link
Contributor Author

zivglik commented Dec 27, 2022

/deploy dev1

@hkube-ci hkube-ci temporarily deployed to dev December 27, 2022 15:54 Inactive
@golanha
Copy link
Member

golanha commented Dec 27, 2022

Test "should succeed to update algorithm only after completed build" fails

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zivglik)

@golanha golanha merged commit a6bddf6 into master Dec 28, 2022
@golanha golanha deleted the add-errors-to-version-not-last branch December 28, 2022 13:54
hkube-ci pushed a commit that referenced this pull request Dec 28, 2022
* add errors to version not last

* fix bug version undefined

* fix lint

* fix test - update algorithm only after completed build .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Dec 28, 2022
* add errors to version not last

* fix bug version undefined

* fix lint

* fix test - update algorithm only after completed build .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants