Node version algorithem #1689
Node version algorithem #1689
Conversation
|
/deploy |
|
/deploy |
|
/deploy |
|
/deploy |
|
/deploy |
|
/deploy |
|
/deploy |
|
/deploy |
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r5, 1 of 1 files at r7, 3 of 3 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zivglik)
core/pipeline-driver/lib/tasks/task-runner.js line 196 at r8 (raw file):
this._isCachedPipeline = await cachePipeline._checkCachePipeline(pipeline.nodes); const nodesModifiedArr = await Promise.all(pipeline.nodes.map(async node => {
you don't need this variable, you can set the pipeline.nodes directly
Code quote:
nodesModifiedArr
|
/deploy |
|
/deploy |
|
/deploy |
There was a problem hiding this comment.
Reviewed 5 of 6 files at r9, 2 of 2 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zivglik)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zivglik)
|
/deploy |
There was a problem hiding this comment.
Reviewable status: 7 of 14 files reviewed, 1 unresolved discussion (waiting on @golanha)
core/pipeline-driver/lib/tasks/task-runner.js line 196 at r8 (raw file):
Previously, golanha (Golan Hallel) wrote…
you don't need this variable, you can set the pipeline.nodes directly
Done.
There was a problem hiding this comment.
Reviewed 5 of 7 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zivglik)
* insert each node version algorithem after run * fix error in cd * fix graph node version algorithm * fix node from pipeline * add async await in loop nodes * fix loop async await * fix foreach nodes * add Promise to nodes * add algorithmVersion to _handleSingle * fix Batch version algorthem * add Algorithms By Version * option to keep old versions after del algorithem * fix codereview remove nodesModifiedArr * update package json new @hkube/db * update package-lock .... bump version [skip ci]
* insert each node version algorithem after run * fix error in cd * fix graph node version algorithm * fix node from pipeline * add async await in loop nodes * fix loop async await * fix foreach nodes * add Promise to nodes * add algorithmVersion to _handleSingle * fix Batch version algorthem * add Algorithms By Version * option to keep old versions after del algorithem * fix codereview remove nodesModifiedArr * update package json new @hkube/db * update package-lock .... bump version [skip ci]
This change is