feat: streaming metrics #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy test |
|
/deploy test |
yehiyam
requested changes
Feb 4, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)
src/utils/graph.js, line 136 at r2 (raw file):
}; let styles; if (metrics) {
how can metrics be null?
nassiharel
commented
Feb 4, 2021
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)
src/utils/graph.js, line 136 at r2 (raw file):
Previously, yehiyam wrote…
how can
metricsbe null?
- batch pipeline
- stream pipeline, on start
yehiyam
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
hkube-ci
pushed a commit
that referenced
this pull request
Feb 4, 2021
* feat: streaming metrics * add deploy to test Co-authored-by: Yehiyam Livneh <yehiyam@gmail.com> .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is