add original flow input

[yehiyam]

This change is 

[yehiyam]

/deploy dev1

[yehiyam]

/deploy dev1

[reggev]

Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @yehiyam)

---

src/components/common/Json/JsonSwitch/JsonSwitch.react.js, line 59 at r3 (raw file):

  // eslint-disable-next-line
  options: PropTypes.object,
  // eslint-disable-next-line

If you don't want to detail the props you can just wrap the whole block with:
/* eslint-disable react/forbid-prop-types /
// ignored props
/ eslint-enable react/forbid-prop-types */
If you can, try to detail as mush as you can, it helps catching errors.

---

src/components/common/Json/JsonSwitch/JsonSwitch.react.js, line 60 at r3 (raw file):

  options: PropTypes.object,
  // eslint-disable-next-line
  jobId: PropTypes.string,

can you provide some default value or pull it to null if nothing is provided?
if it's required then mark it as required

---

src/components/common/Json/JsonTable/JsonTable.react.js, line 47 at r3 (raw file):

        <>
          <Button onClick={handleDownload}>Download</Button>
          <a

Iv'e implemented a file called DownloadLink.js on a branch 'bugfix-datasources', that does this whole process of creating a link and clicking it whenever the href prop changes
It'll be better if you use that, I'm trying to get rid of all the uses of the socket's URL (or any other URL constructing method) inside the components...

---

src/components/common/Json/JsonTable/JsonTable.react.js, line 93 at r3 (raw file):

  isMargin: PropTypes.bool,
  key: PropTypes.oneOf([PropTypes.string, PropTypes.number]),
  jobId: PropTypes.string,

Is it a required property?

---

src/hooks/usePipeline.js, line 28 at r3 (raw file):

    [updateStored]
  );
  const rerunRawPipeline = async (pipeline, jobId) => {

consider wrapping this in a useCallback

[yehiyam]

Reviewable status: 0 of 6 files reviewed, 5 unresolved discussions (waiting on @reggev)

---

src/components/common/Json/JsonSwitch/JsonSwitch.react.js, line 59 at r3 (raw file):

Previously, reggev wrote…

If you don't want to detail the props you can just wrap the whole block with:
/* eslint-disable react/forbid-prop-types /
// ignored props
/ eslint-enable react/forbid-prop-types */
If you can, try to detail as mush as you can, it helps catching errors.

added more detail

---

src/components/common/Json/JsonSwitch/JsonSwitch.react.js, line 60 at r3 (raw file):

Previously, reggev wrote…

can you provide some default value or pull it to null if nothing is provided?
if it's required then mark it as required

made it required

---

src/components/common/Json/JsonTable/JsonTable.react.js, line 47 at r3 (raw file):

Previously, reggev wrote…

Iv'e implemented a file called DownloadLink.js on a branch 'bugfix-datasources', that does this whole process of creating a link and clicking it whenever the href prop changes
It'll be better if you use that, I'm trying to get rid of all the uses of the socket's URL (or any other URL constructing method) inside the components...

Done.

---

src/components/common/Json/JsonTable/JsonTable.react.js, line 93 at r3 (raw file):

Previously, reggev wrote…

Is it a required property?

Done.

---

src/hooks/usePipeline.js, line 28 at r3 (raw file):

Previously, reggev wrote…

consider wrapping this in a useCallback

not sure how can I use useCallback here

[yehiyam]

/deploy dev1

[reggev]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @yehiyam)

---

src/hooks/usePipeline.js, line 28 at r3 (raw file):

Previously, yehiyam wrote…

not sure how can I use useCallback here

I added for you

[reggev]

/deploy dev1

[reggev]

/deploy dev1

[reggev]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @yehiyam)