-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmchart hetzner csi #1417
Helmchart hetzner csi #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I will test it.
Edit: It's creating the storageclass correctly, so assuming all is good.
The merge-base changed after approval.
@@ -305,7 +316,6 @@ resource "null_resource" "kustomization" { | |||
"set -ex", | |||
"kubectl -n kube-system create secret generic hcloud --from-literal=token=${var.hcloud_token} --from-literal=network=${data.hcloud_network.k3s.name} --dry-run=client -o yaml | kubectl apply -f -", | |||
"kubectl -n kube-system create secret generic hcloud-csi --from-literal=token=${var.hcloud_token} --dry-run=client -o yaml | kubectl apply -f -", | |||
local.csi_version != null ? "curl https://raw.githubusercontent.com/hetznercloud/csi-driver/${coalesce(local.csi_version, "v2.4.0")}/deploy/kubernetes/hcloud-csi.yml -o /var/post_install/hcloud-csi.yml" : "echo 'Skipping hetzner csi.'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an existing cluster is updated, the resources created by this manifest are not automatically deleted. Could there be some way to automate this part, instead of having to manually search for why the helm chart fails to apply? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tooboredtocode I believe it's risky to do so on live clusters, so prefer to not mess around with that. However, please feel free to write a guide below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tooboredtocode did you find an approach to this? Did manually deleting the resources impact your volumes or was the move to Helm non-breaking? What steps did you follow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted the old files and let the terraform script apply all changes, that did it. Though I locked all Volumes as a safety measure in the Dashboard.
fixes #1416
I am not sure whether this works, because I just realised I never used the hetzner csi.
but I think it should
builds upon #1415