Fix first control planed depending on kustomization_backup #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticaltech
changed the title
mysticaltech
requested review from
aleksasiriski,
karbowiak,
valkenburg-prevue-ch,
M4t7e and
ifeulner
mysticaltech
commented
Aug 1, 2023
mysticaltech
commented
Aug 1, 2023
M4t7e
reviewed
Aug 1, 2023
|
@M4t7e Are we good to go? Basically, we do not need for it to be applied to backup, and it fixes the "uniqueness" of the first control plane, super useful when the it goes down for any reason, to be able to rebuild it wihtout problems. This is tested and verified by the way, everything works. |
M4t7e
approved these changes
Aug 3, 2023
|
@mysticaltech LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #913, and allows for this #913 (comment).