Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CCM Webhook Listener Port Collision #938

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

M4t7e
Copy link
Contributor

@M4t7e M4t7e commented Aug 18, 2023

This PR fixes #934

It seems K3s CCM is (partially) active in case Klipper LB is used. In this situation, if Hetzner CCM (HCCM) is running on a CP node, there will be a port conflict as both K3s CCM and HCCM try to bind to port 10260. This is caused by a new feature introduced in Kubernetes 1.27 with kubernetes/kubernetes#108838.

Thanks to @apricote we have a workaround to disable the HCCM webhook listener by adding --webhook-secure-port=0 flag to HCCM. This can be used in HCCM > v1.16.0.

See also kubernetes/kubernetes#120043.

I tested this flag with and without using Klipper LB and it seems to work fine 🙂

@apricote
Copy link
Contributor

Thanks to @apricote we have a workaround to disable the HCCM webhook listener by adding --webhook-secure-port=0 flag to HCCM. This can be used in HCCM from v1.27.2.

This flag can be used in any version of HCCM > v1.16.0 (which upgraded to kubernetes 1.27 dependencies). It is not necessary from v1.27.2, as its now part of the HCCM published manifests.

@M4t7e
Copy link
Contributor Author

M4t7e commented Aug 18, 2023

Thanks for the clarification @apricote

I have adjusted the description accordingly.

@mysticaltech mysticaltech merged commit e79cfc7 into kube-hetzner:staging Aug 23, 2023
1 check passed
@mysticaltech
Copy link
Collaborator

@M4t7e @apricote Thanks for this, just released in v2.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants