Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform provider versions #993

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Update terraform provider versions #993

merged 7 commits into from
Sep 26, 2023

Conversation

RelativeSure
Copy link
Contributor

No description provided.

@RelativeSure RelativeSure changed the title Update hcloud version in modules Update terraform provider versions Sep 23, 2023
@RelativeSure
Copy link
Contributor Author

image

@mysticaltech
Copy link
Collaborator

@RelativeSure Thanks for this, super important indeed. Please could you also check kube.tf.example, I believe it has some versions to upgrade in there too.

mysticaltech
mysticaltech previously approved these changes Sep 25, 2023
Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your terraform lock state

@mysticaltech
Copy link
Collaborator

@RelativeSure , about the terraform lock file, @aleksasiriski has a point, I understand the recommendation from terraform, however this does not apply to that repo that is just a module. In the place where you use the kube-hetzner module, you can commit that state indeed.

@RelativeSure
Copy link
Contributor Author

@RelativeSure , about the terraform lock file, @aleksasiriski has a point, I understand the recommendation from terraform, however this does not apply to that repo that is just a module. In the place where you use the kube-hetzner module, you can commit that state indeed.

Thanks for the explanation! File has been removed and I added back the line in gitignore. I also added the final line in gitignore just so git can be happy :)

@aleksasiriski aleksasiriski changed the base branch from master to staging September 26, 2023 11:27
@aleksasiriski aleksasiriski merged commit ebb5a71 into kube-hetzner:staging Sep 26, 2023
1 check passed
@RelativeSure RelativeSure deleted the patch-1 branch September 26, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants