-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terraform provider versions #993
Conversation
@RelativeSure Thanks for this, super important indeed. Please could you also check kube.tf.example, I believe it has some versions to upgrade in there too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove your terraform lock state
@RelativeSure , about the terraform lock file, @aleksasiriski has a point, I understand the recommendation from terraform, however this does not apply to that repo that is just a module. In the place where you use the kube-hetzner module, you can commit that state indeed. |
Thanks for the explanation! File has been removed and I added back the line in gitignore. I also added the final line in gitignore just so git can be happy :) |
No description provided.