select version by priority rather than picking first #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses master version of kube for this with the newly merged kube::core::Version add (will be avialable in 0.66.0) Signed-off-by: clux <sszynrae@gmail.com>
|
Looks good. Nice touch sorting |
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses master version of kube for this with the newly merged
kube::core::Versionadd (will be avialable in 0.66.0)only did the basics here of linking up the feature we did in kube-rs/kube#764
we still need some way of testing this - and haven't gotten a crd to test out multi version atm.
replaces #24 for #23 - but needs some way of testing it. @imp if you are free - some review / future help here would be great.
if not, i'll pick this up at some point over the new year - and enjoy the end of your year :-)